Re: [PATCH net v3 2/2] net: pcs: xpcs: make supported_interfaces authoritative
From: Paolo Abeni
Date: Tue Nov 10 2026 - 10:31:55 EST
On 11/2/26 22:25, Coia Prant wrote:
diff --git a/drivers/net/pcs/pcs-xpcs-rk.c b/drivers/net/pcs/pcs-xpcs-rk.c
index 6f0a110e32d2..25fdc9c6b72c 100644
--- a/drivers/net/pcs/pcs-xpcs-rk.c
+++ b/drivers/net/pcs/pcs-xpcs-rk.c
@@ -483,6 +483,7 @@ struct dw_xpcs *xpcs_rk_create(struct device *dev, struct device_node *pcs, int
struct platform_device *pdev;
struct dw_xpcs_rk *pxpcs;
struct dw_xpcs *xpcs;
+ DECLARE_PHY_INTERFACE_MASK_ZERO(supported_interfaces);
Please respect the reverse christmas tree order above.
if (!of_device_is_available(pcs))
return ERR_PTR(-ENODEV);
@@ -536,6 +537,15 @@ struct dw_xpcs *xpcs_rk_create(struct device *dev, struct device_node *pcs, int
return xpcs;
}
+ /*
+ * The RK3568 XPCS supports 1000BASE-X, SGMII and QSGMII.
+ */
+ __set_bit(PHY_INTERFACE_MODE_1000BASEX, supported_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_SGMII, supported_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_QSGMII, supported_interfaces);
Sashiko thinks this last statement is a no op:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261102212506.3348537-1-coiaprant@xxxxxxxxx
I don't think this is 'net' material, I suggest resubmitting for
net-next.
/P