Re: [PATCH 04/11] pinctrl: scmi: report an off setting as not set
From: Cristian Marussi
Date: Tue Nov 10 2026 - 10:46:58 EST
On Tue, Nov 10, 2026 at 03:47:33PM +0100, Clément Le Goffic wrote:
> Hi Cristian,
>
> On 11/10/26 12:24 PM, Cristian Marussi wrote:
> > On Fri, Oct 30, 2026 at 04:58:35PM +0100, Clément Le Goffic wrote:
> >> A get of a setting that is on or off, the flags and the pulls, returned
> >> 0 as a value, so every one of them showed as set on every pin. Return
> >> -EINVAL when the platform answers 0, which is how pinconf reports a
> >> setting that is not active.
> >>
> >> Fixes: eb524cb651b7 ("pinctrl: Implementation of the generic scmi-pinctrl driver")
> >> Signed-off-by: Clément Le Goffic <clegoffic@xxxxxxxxxxxx>
> >> ---
> >
> > LGTM.
> > Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>
>
> I'll apply Andy remarks. Can I keep your Reviewed-by with those fixes?
Sure.
Cristian