Re: [PATCH net 1/2] selftests: drv-net: ring_reconfig: handle devices without channel config

[Bilal Yazıcıoğlu]

On Tue, 10 Nov 2026, netdev-bot+sashiko@xxxxxxxxxx wrote:
> This catches EOPNOTSUPP from channels_get, but what about drivers that
> implement get_channels but not set_channels?
[...]
> Could the channels_set call get the same handling, i.e. log with
> ksft_pr() and return on EOPNOTSUPP before registering the defer?

Good catch, that's a real gap. ethnl_set_channels_validate() rejects
the change with -EOPNOTSUPP when there is no set_channels, and a few
drivers only implement get_channels (vmxnet3, r8169, enic, octeon_ep
and others), so ringparam() still fails on them.

The upcoming v2 handles it the way you suggest. Looking at the same
drivers, channels() also fails there (its restore gets -EOPNOTSUPP),
and so does reconfig_tx_stall() when a driver reports spare combined
channels, so v2 skips those cases too. Other errors still fail.

I don't have any of those NICs, so that part is only tested against
an emulated ethtool family.

pw-bot: cr