Re: [PATCH v4 4/4] platform/x86: bitland-mifs-wmi: Cycle the platform profile on Fn+K

[Chris Taraszka]

On Fri, 6 Nov 2026, Mingyou Chen wrote:
> Does this quirk entry really necessary?
>
> Since only supported hardware sends 0x28. And 0x28 is not used for other
> proposes.

No, I'll drop it in v5 and cycle on 0x28 for every model, so the TM2424
patch stays as it is and keeps your Reviewed-by. Retested without the
flag on v7.4-rc1, on battery: three Fn+K presses from low-power set
0x09, 0x03 and 0x02, each followed by a single 0x16.

I'll send v5 on top of your next version of the merge series, or on
v15 if it stays.

Thanks,
Chris


On Fri, Nov 6, 2026 at 2:19 PM Mingyou Chen <qby140326@xxxxxxxxx> wrote:
>
> On 11/6/26 19:43, Chris Taraszka wrote:
> > On the Xiaomi Book Pro 14 (TM2424), Fn+K sends hotkey event 0x28 and
> > the firmware does not change SystemPerMode itself. The event is a
> > request that the vendor software acts on; without that software Fn+K
> > does nothing on Windows either, and on Linux it is currently logged as
> > an unknown event.
> >
> > Add a quirk for this and call platform_profile_cycle() from the control
> > device when the event arrives, so Fn+K cycles through the profiles that
> > all platform profile handlers support. Models without the quirk keep
> > ignoring the event.
> >
> > Suggested-by: Hans de Goede <hansg@xxxxxxxxxx>
> > Signed-off-by: Chris Taraszka <chris@xxxxxxxxx>
> > ---
> >
> > Notes:
> >      Unchanged since v3.
> >
> >   drivers/platform/x86/bitland-mifs-wmi.c | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
> > index 4d02cd9e8a6b..84d1223d0ec6 100644
> > --- a/drivers/platform/x86/bitland-mifs-wmi.c
> > +++ b/drivers/platform/x86/bitland-mifs-wmi.c
> > @@ -100,6 +100,9 @@ struct bitland_mifs_quirks {
> >
> >       bool return_code_at_end;
> >       bool skip_ac_type_check;
> > +
> > +     /* Fn+K sends WMI_EVENT_PERFORMANCE_CYCLE and leaves the mode to the OS */
> > +     bool cycle_profile_on_key;
>
> Does this quirk entry really necessary?
>
> Since only supported hardware sends 0x28. And 0x28 is not used for other
> proposes.
>
> >   };
> >
> >   static const struct bitland_profile_entry default_profile_entries[] = {
> > @@ -126,6 +129,7 @@ static const struct bitland_mifs_quirks tm2424_quirks = {
> >       .profile_entries = tm2424_profile_entries,
> >       .num_profile_entries = ARRAY_SIZE(tm2424_profile_entries),
> >       .skip_ac_type_check = true,
> > +     .cycle_profile_on_key = true,
> >   };
> >
> >   static const struct dmi_system_id bitland_mifs_dmi_table[] = {
> > @@ -169,6 +173,7 @@ enum bitland_mifs_event_id {
> >       WMI_EVENT_MIC_MUTE              = 33,
> >       WMI_EVENT_RESERVED_23           = 34,
> >       WMI_EVENT_OPEN_APP              = 35,
> > +     WMI_EVENT_PERFORMANCE_CYCLE     = 40,
> >   };
> >
> >   enum bitland_mifs_event_type {
> > @@ -217,6 +222,7 @@ static BLOCKING_NOTIFIER_HEAD(bitland_notifier_list);
> >   enum bitland_notifier_actions {
> >       BITLAND_NOTIFY_KBD_BRIGHTNESS,
> >       BITLAND_NOTIFY_PLATFORM_PROFILE,
> > +     BITLAND_NOTIFY_PLATFORM_PROFILE_CYCLE,
> >       BITLAND_NOTIFY_HWMON,
> >   };
> >
> > @@ -869,6 +875,10 @@ static int bitland_notifier_callback(struct notifier_block *nb,
> >       case BITLAND_NOTIFY_PLATFORM_PROFILE:
> >               platform_profile_notify(data_ctx->pp_dev);
> >               break;
> > +     case BITLAND_NOTIFY_PLATFORM_PROFILE_CYCLE:
> > +             if (data_ctx->pp_dev)
> > +                     platform_profile_cycle();
> > +             break;
> >       case BITLAND_NOTIFY_HWMON:
> >               fan_info = data;
> >
> > @@ -1015,6 +1025,7 @@ static void bitland_mifs_wmi_report_key(struct wmi_device *wdev, u32 payload)
> >   static void bitland_mifs_wmi_notify(struct wmi_device *wdev,
> >                                   const struct wmi_buffer *buffer)
> >   {
> > +     struct bitland_mifs_wmi_data *data = dev_get_drvdata(&wdev->dev);
> >       const struct bitland_mifs_event *event = buffer->data;
> >       struct bitland_fan_notify_data fan_data;
> >       u8 brightness;
> > @@ -1043,6 +1054,15 @@ static void bitland_mifs_wmi_notify(struct wmi_device *wdev,
> >                                            NULL);
> >               return;
> >
> > +     case WMI_EVENT_PERFORMANCE_CYCLE:
> > +             if (!data->quirks->cycle_profile_on_key)
> > +                     break;
> > +
> > +             blocking_notifier_call_chain(&bitland_notifier_list,
> > +                                          BITLAND_NOTIFY_PLATFORM_PROFILE_CYCLE,
> > +                                          NULL);
> > +             return;
> > +
> >       /*
> >        * The device has 3 fans (CPU, GPU, SYS),
> >        * but there are only the CPU and GPU fan has events