Re: [PATCH] USB: legousbtower: use stream_open for stream semantics

[mdshahid03]

Hi,

Could you please review patch and give your feedback,when time permits.

Thanks
Shahid.

On 2026-10-28 23:58 +0530, mdshahid03@xxxxxxxxx wrote:
> From: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> 
> The LEGO USB Tower driver uses nonseekable_open() in tower_open()
> However, its read and write have stream semantics.
> 
> Use stream_open instead to mark the file as a stream and disable
> unnecessary file position handling.
> 
> The issue is reported by stream_open.cocci script as potential
> deadlock between read and write operation.
> 
> Signed-off-by: Mohammad Shahid <mdshahid03@xxxxxxxxx>
> ---
>  drivers/usb/misc/legousbtower.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
> index 18dd4115befb..b849bd0e9664 100644
> --- a/drivers/usb/misc/legousbtower.c
> +++ b/drivers/usb/misc/legousbtower.c
> @@ -313,7 +313,7 @@ static int tower_open(struct inode *inode, struct file *file)
>  	struct tower_reset_reply reset_reply;
>  	int result;
>  
> -	nonseekable_open(inode, file);
> +	stream_open(inode, file);
>  	subminor = iminor(inode);
>  
>  	interface = usb_find_interface(&tower_driver, subminor);
> -- 
> 2.43.0
> 
>