Re: [PATCH] net/mlx5e: TC, release meter if rule offload fails

[Tariq Toukan]

On 10/11/2026 5:45, Jianbo Liu wrote:
> Hi Wentao,
>
> Thanks for the fix, the leak is real. This comment is valid too:
> mlx5e_tc_del_flow_meter() leaves the pointers set, and
> mlx5e_tc_rule_unoffload() releases the meter whenever
> attr->meter_attr.meter is non-NULL. After a failed re-offload in
> mlx5e_reoffload_encap() the flow is still marked OFFLOADED, so the next
> unoffload releases the meter and post meter a second time.
>
> Please clear both pointers in mlx5e_tc_del_flow_meter() in v2. The
> dest_ft part is not needed, the next mlx5e_tc_add_flow_meter() sets it
> again before it is used.
>
> Thanks,
> Jianbo

pw-bot: cr