Re: [PATCH] PCI: pciehp: Fix NULL pointer dereference in pciehp_configure_device()

[Priyank Rathod]

On Tue, Nov 10, 2026 at 04:43:52PM +0100, Niklas Schnelle wrote:
> On Tue, 2026-11-10 at 11:04 +0100, Lukas Wunner wrote:
> > Are you actually observing a crash in practice because of a missing NULL
> > pointer check?
>
> FWIW we (s390) do not use pciehp we use our own s390_pci_hpc for
> hotplug. I'd be interested if this comes out of a real issue or just an
> LLM worry too though.

Hi Lukas, Niklas,

No crash was observed in practice -- this came from static inspection,
and even reproducing it in QEMU requires patching QEMU's pcie-root-port
to bypass its Function 0 hotplug checks in addition to
hypervisor_isolated_pci_functions() returning true.

Since this isn't reachable on unmodified hypervisors and Terry's pending
patch removes ctrl->dsn and those lines altogether, please consider this
patch withdrawn.  Thanks for the pointer and clarification!

Best regards,
Priyank