Re: [PATCH] i2c: slave-eeprom: Add an OF match table for module autoload
From: Uwe Kleine-König
Date: Tue Nov 10 2026 - 13:18:34 EST
Hello,
On Tue, Nov 10, 2026 at 05:34:54AM +0000, Arun Iyengar wrote:
> diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
> index 226d722af662..a08abd895412 100644
> --- a/drivers/i2c/i2c-slave-eeprom.c
> +++ b/drivers/i2c/i2c-slave-eeprom.c
> @@ -20,6 +20,7 @@
> #include <linux/firmware.h>
> #include <linux/i2c.h>
> #include <linux/init.h>
> +#include <linux/mod_devicetable.h>
Please don't add that include. <linux/i2c.h> already provides
of_device_id without introducing useless build dependencies.
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/slab.h>
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature