Re: [PATCH net v2] tcp: fix device binding after failed IPv6 connect

From: Jakub Kicinski

Date: Tue Nov 10 2026 - 14:44:00 EST


On Mon, 2 Nov 2026 22:34:52 +0800 Xia Yan wrote:
> + if (scope_id_set &&
> + READ_ONCE(sk->sk_bound_dev_if) == usin->sin6_scope_id)
> + WRITE_ONCE(sk->sk_bound_dev_if, old_bound_dev_if);
> + scope_id_set = false;

Just restore the old_bound_dev_if, I don't think we need all these
pre-conditions complicating the code. __ip6_datagram_connect()
already restores unconditionally for example.
--
pw-bot: cr