Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages()

[David Hildenbrand (Arm)]

On 11/10/26 21:19, Yeoreum Yun wrote:
> On Tue, Nov 10, 2026 at 02:21:18PM -0500, Rik van Riel wrote:
>> On Tue, 2026-11-10 at 14:04 +0100, David Hildenbrand (Arm) wrote:
>>>
>>> Not quite the right semantics. For pagecache folios we simply don't
>>> need
>>> unsharing in MAP_SHARED VMAs. That does not imply that these are
>>> exclusive.
>>>
>>> So it's all about "number of pages that don't need unsharing".
>>>
>> gup_no_unshare_len() ?
>>
>> a little awkward sounding, but it describes
>> what it's doing?
> 
> Hmm, Wouldn't this name be semantically much the same as keeping
> the existing gup_unshared_page(), since both essentially convey that
> no unsharing is required from GUP's perspective?
> 
> Anyway, naming is always NP-hard problem :\
> 
> 

gup_skip_unshare_pages

not sure

-- 
Cheers,

David