Re: [PATCH wireless-next v4 02/21] wifi: nl80211/cfg80211: define interfaces for SMD setup and STA update
From: Johannes Berg
Date: Tue Nov 10 2026 - 16:33:37 EST
On Fri, 2026-11-06 at 13:28 +0530, Pooventhiran G wrote:
> +/**
> + * struct cfg80211_sta_smd_params - SMD parameters for an added station
> + *
> + * @smd_sta: SMD-negotiated STA
> + * @roam_sta: station was created via SMD BSS Transition procedure
> + */
> +struct cfg80211_sta_smd_params {
> + bool smd_sta;
I don't understand why the kernel should care about whether or not the
non-AP MLD negotiated SMD. It's a single bit, and has no bearing on any
kernel functionality, it's mostly just a change in key derivation.
> + bool roam_sta;
This is also entirely unused.
And then basically this whole patch goes away.
johannes