Re: [PATCH v3 0/4] tools build: Fixes for libbfd -lzstd dependency

[Ian Rogers]

On Tue, Nov 3, 2026 at 8:30 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> This series addresses build problems when linking against static
> libbfd/libopcodes on distributions like Fedora where binutils is built
> with zstd section decompression support (requiring '-liberty -lz -lzstd'
> together).

Hi,

Namhyung/Arnaldo, could you help review the tools/build and tools/perf
parts of this (patches 1 and 2)? The objtool and bpftool changes have
Peter's and Quentin's tags.

Thanks,
Ian

> In v2, commit 89d001d48ec7 ("tools build: Add zstd to the binutils
> library feature tests") landed in tools/build/feature/Makefile at the
> same time, creating a merge conflict and only adding '|| $(BUILD_BFD)
> -lzstd' without '-liberty -lz' or the corresponding
> libbfd-liberty-z-zstd feature check in perf and bpftool (so even if
> test-libbfd.bin passed with -lzstd, perf and bpftool would link only
> '-lbfd -lopcodes' without '-lzstd').
>
> v3 rebases onto perf-tools-next (v7.4-rc1), fixes commit 89d001d48ec7 in
> patch 1/4, collects the Acked-by tags from Quentin Monnet and Peter
> Zijlstra, updates the LIBOPCODES_LIBS comment in tools/objtool/Makefile,
> and moves the AI assistance disclosure from commit trailers to the cover
> letter.
>
> v2: https://lore.kernel.org/all/20260909204122.1993010-1-irogers@xxxxxxxxxx/
> v1: https://lore.kernel.org/linux-perf-users/20260909181030.1870496-1-irogers@xxxxxxxxxx/
>
> AI Assistance Disclosure (per Documentation/process/coding-assistants.rst):
> - Tools used: Antigravity coding assistant and Sashiko automated patch
>   review.
> - Summary of prompts and assistance: Rebased the 4-patch series onto
>   perf-tools-next, resolved the conflict with commit 89d001d48ec7 in
>   tools/build/feature/Makefile, incorporated review feedback and
>   Acked-by tags, and verified with scripts/checkpatch.pl.
>
> Ian Rogers (4):
>   tools build: Add explicitly sequenced -lzstd to libbfd feature
>     fallback
>   perf build: Add explicitly sequenced -lzstd to libbfd feature fallback
>   bpftool: Add explicitly sequenced -lzstd to libbfd feature fallback
>   objtool: Add explicitly sequenced -lzstd to libopcodes fallback
>
>  tools/bpf/bpftool/Makefile   |  4 ++++
>  tools/build/Makefile.feature |  3 ++-
>  tools/build/feature/Makefile | 19 +++++++++++++------
>  tools/objtool/Makefile       |  7 ++++---
>  tools/perf/Makefile.config   |  3 +++
>  5 files changed, 26 insertions(+), 10 deletions(-)
>
> --
> 2.56.0.385.gac671c819a-goog
>