Re: [PATCH v2 3/6] dt-bindings: clock: ath79: add the UART1 clock

[Rosen Penev]

On Tue, Nov 10, 2026 at 5:25 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Mon, Nov 09, 2026 at 05:36:43PM -0800, Rosen Penev wrote:
> > AR934x has a second, high speed UART that is compatible with the
> > qca,ar9330-uart one and can run from a 100 MHz clock instead of the
> > reference clock. Add an ID for its clock.
> >
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > ---
> >  include/dt-bindings/clock/ath79-clk.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/clock/ath79-clk.h b/include/dt-bindings/clock/ath79-clk.h
> > index eec8f399b9e6..f8a98e4d206d 100644
> > --- a/include/dt-bindings/clock/ath79-clk.h
> > +++ b/include/dt-bindings/clock/ath79-clk.h
> > @@ -11,7 +11,8 @@
> >  #define ATH79_CLK_AHB                2
> >  #define ATH79_CLK_REF                3
> >  #define ATH79_CLK_MDIO               4
> > +#define ATH79_CLK_UART1              5
> >
> > -#define ATH79_CLK_END                5
> > +#define ATH79_CLK_END                6
>
> You cannot change that, that's fixed ABI.
There are commits like 2f4788cca881 that remove CLK_END. I agree with
those commits. This define should not be here.
>
> Best regards,
> Krzysztof
>