Re: [PATCH v3 2/7] dt-bindings: media: qcom,sm8150-camss: Add SM8150 CAMSS
From: Andrew Gigena
Date: Tue Nov 10 2026 - 18:46:36 EST
Hi Vladimir,
> That's an intermix of names, and you will get a review comment from
> Krzysztof about it, I stand aside.
>
> Here too.
Krzysztof did comment. I kept the vfe0/csid0/vfe1/csid1 order from
sc8280xp-camss.yaml in reg-names and interrupt-names, and asked him if
he prefers another grouping.
> Drop 'gcc_axi_sf'.
Downstream sm8150-camera.dtsi feeds GCC_CAMERA_SF_AXI_CLK to CPAS and
x1e80100-camss.yaml has gcc_axi_sf, so it is used. Can you explain why it
should go?
> Drop 'cam_' prefix and 'cam_sf_0_mnoc' also.
Prefix dropped. I kept sf_0_mnoc because SM8150 has a CAMNOC SF path.
Should I remove it too?
> Or C-PHY, right?..
> In fact you shall drop bus-type from here, because the link between
> CAMSS and PHY's output is not a CSI-2 bus, it makes it inapplicable.
Agreed, bus-type is gone from the CAMSS ports. It only exists on the PHY
sensor input now.
Best regards,
Andrew