RE:(2) [PATCH 1/2] xfs: number the cache flushes submitted to each buftarg

[Daejun Park]

On Mon, Nov 09, 2026 at 12:44:07PM -0500, Brian Foster wrote:
> > +	iclog->ic_flush_seq = 0;
> > +	if (iclog->ic_bio.bi_opf & REQ_PREFLUSH)
> > +		iclog->ic_flush_seq = xfs_buftarg_flush_start(log->l_targ);
>
> Bit of a nit, but it looks like this would be cleaner if we moved both
> of these a bit further up. I.e., zero ->ic_flush_seq right after where
> we init the iclog->ic_bio fields, and then move the assignment under the
> same block where we set the PREFLUSH flag. Hm?

Thanks, agreed. In v2 xlog_write_iclog() will zero ic_flush_seq right
after the ic_bio setup and take the number in the branch that sets
REQ_PREFLUSH.