Re: [PATCH v3 11/13] gpu: nova-core: falcon: use src_start as FB offset for all DMA transfers
From: Eliot Courtney
Date: Tue Nov 10 2026 - 20:44:59 EST
On Tue Nov 10, 2026 at 7:21 PM JST, Alexandre Courbot wrote:
> dma_wr() splits the source offset of a transfer between DMATRFBASE and
> DMATRFFBOFFS differently depending on the target memory. This separation
> adds branching to the code, and is not strictly needed as DMATRFFBOFFS
> supports 32-bit offsets.
>
> Remove that distinction by programming the start of the source into
> DMATRFBASE and `src_start` into DMATRFFBOFFS for all transfers, which
> also removes the `fb_offset` and `base_offset` local variables.
>
> This changes the register values programmed for untagged DMEM
> transfers, but not the addresses they read from. No change of behavior
> has been observed on either r570 or r615.
>
> Suggested-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/DMQI0G2K6Z3B.1YEH6D2ZILRBI@xxxxxxxxxx/
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>