Re: [PATCH] powerpc/perf/vpa-dtl: use GFP_ATOMIC for DTL buffer allocation

[IBM]

mdshahid03@xxxxxxxxx writes:

> From: Mohammad Shahid <mdshahid03@xxxxxxxxx>
>
> The DTL buffer is allocated while holding dtl_global_lock, which
> is spinlock.
>
> GFP_KERNEL allow direct memory reclaim and may sleep. Combining
> GFP_KERNEL with GFP_ATOMIC does not remove the direct reclaim.
>
> Use GFP_ATOMIC alone to ensure the allocation does not sleep
> while the spinlock is held.
>
> The issue is reported by script coccinelle call_kern.cocci.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@xxxxxxxxx>

This make sense. However we should also add fixes tag and tag stable
so it gets backported to stable trees as well.

Fixes: 4708fba19ade ("powerpc/vpa_dtl: Add interface to expose vpa dtl counters via perf")
Cc: stable@xxxxxxxxxxxxxxx

LGTM, so feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>