Re: [PATCH v2 00/12] klp-build: Fix dependent patches, add selftests

[Song Liu]

On Tue, Nov 10, 2026 at 4:45 AM Petr Mladek <pmladek@xxxxxxxx> wrote:
>
[...]
> >  create mode 100755 scripts/livepatch/klp-prepare-patch
> >  create mode 100644 tools/testing/selftests/livepatch/test_klp_build/Makefile
> >  create mode 100644 tools/testing/selftests/livepatch/test_klp_build/functions.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/run-tests.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-basic.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-cancelling-patches.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-independent-patches.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-line-directives.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-new-and-deleted-files.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-offset-and-fuzz.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-patch-not-applying.sh
> >  create mode 100755 tools/testing/selftests/livepatch/test_klp_build/test-unsupported-files.sh
>
> I am sorry, I am overloaded and do not have time for a proper review.

No worries.

> I just see that it adds a lot of new files. And I wonder how much it
> shares with the livepatch selftests. Would it make sense to put
> it into a separate directory, e.g. tools/testing/selftests/klp-build ?

This set of tests is mostly independent to current livepatch selftests.
But in the longer term, as we add more end to end tests with klp-build,
there will be more overlap between klp-build tests, and livepatch tests.

Thanks,
Song