Re: [PATCH] powerpc/smp: Handle of_property_count_u32_elems() error in parse_thread_groups()
From: Nathan Chancellor
Date: Tue Nov 10 2026 - 23:30:16 EST
On Tue, Nov 10, 2026 at 02:58:32PM +0530, Shrikanth Hegde wrote:
> Looks fine to me.
> Reviewed-by: Shrikanth Hegde <sshegde@xxxxxxxxxxxxx>
Thanks a lot for taking a look!
> Should the similar fix is needed here as well?
>
> arch/powerpc/platforms/powernv/idle.c:
> nr_idle_states = of_property_count_u32_elems(np,
> "ibm,cpu-idle-state-flags");
>
> pnv_idle_states = kzalloc_objs(*pnv_idle_states, nr_idle_states);
> temp_u32 = kzalloc_objs(u32, nr_idle_states);
> temp_u64 = kzalloc_objs(u64, nr_idle_states);
> temp_string = kcalloc(nr_idle_states, sizeof(char *), GFP_KERNEL);
More than likely. Maybe someone from IBM can validate and send a patch.
--
Cheers,
Nathan