Re: [PATCH v2 3/8] xen: Add gpa conversion helpers

[Juergen Gross]

On 16.10.26 19:06, Teddy Astie wrote:
> Introduce various helpers to convert between GPA and virt/paddr.
>
> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

If you are up to it, there is some potential for cleaning up the Xen related
page.h include files.

You are adding the same definitions to the x86 and arm specific page.h files,
which are located at different positions regarding the arch trees.

I think this should be cleaned up by moving the common parts into
include/xen/page.h. The arch specific include files should both be under
include/xen/<arch>/page.h, I think (using arch/<arch>/include/asm/xen/page.h
won't work, as the arm file is used by arm and arm64).

In case you don't want to do that, I'm fine to do that later, e.g. when the
riscv Xen port is arriving in the kernel.


Juergen

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature