[PATCH v2 09/33] HID: logitech-hidpp: initialize response buffer before publishing send_receive_buf

From: Dmitry Torokhov

Date: Wed Nov 11 2026 - 02:10:03 EST


__do_hidpp_send_message_sync() publishes send_receive_buf before
initializing the response buffer. hidpp_raw_hidpp_event() runs in IRQ or
softirq context without taking send_mutex whenever the mutex is locked,
reading question and answer from send_receive_buf. If an incoming report
arrives after send_receive_buf is published but before response is
populated, hidpp_match_answer() inspects uninitialized memory.

Initialize response with the outgoing message and clear answer_available
before publishing send_receive_buf with release semantics, clear the
pointer with WRITE_ONCE() on completion, and read it once with acquire
semantics in the event handler.

Fixes: 2f31c5252910 ("HID: Introduce hidpp, a module to handle Logitech hid++ devices")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
---
drivers/hid/hid-logitech-hidpp.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index c486488efe99..16dcd79059d5 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -300,14 +300,17 @@ static int __do_hidpp_send_message_sync(struct hidpp_device *hidpp,

__must_hold(&hidpp->send_mutex);

- hidpp->send_receive_buf = response;
- hidpp->answer_available = false;
-
/*
* So that we can later validate the answer when it arrives
* in hidpp_raw_event
*/
*response = *message;
+ hidpp->answer_available = false;
+ /*
+ * Pairs with smp_load_acquire() in hidpp_raw_hidpp_event() to ensure
+ * the response buffer initialization is visible before publishing.
+ */
+ smp_store_release(&hidpp->send_receive_buf, response);

ret = __hidpp_send_report(hidpp->hid_dev, message);
if (ret) {
@@ -342,7 +345,7 @@ static int __do_hidpp_send_message_sync(struct hidpp_device *hidpp,
ret = 0;

out:
- hidpp->send_receive_buf = NULL;
+ WRITE_ONCE(hidpp->send_receive_buf, NULL);
return ret;
}

@@ -4148,12 +4151,16 @@ static int hidpp_raw_hidpp_event(struct hidpp_device *hidpp, u8 *data,
* previously sent command.
*/
if (unlikely(mutex_is_locked(&hidpp->send_mutex))) {
- question = hidpp->send_receive_buf;
- answer = hidpp->send_receive_buf;
-
+ /*
+ * Pairs with smp_store_release() in __do_hidpp_send_message_sync()
+ * to ensure the initialized response buffer is observed.
+ */
+ question = smp_load_acquire(&hidpp->send_receive_buf);
if (!question)
return 0;

+ answer = question;
+
/*
* Check for a correct hidpp20 answer or the corresponding
* error

--
2.56.0.542.g3ef89b7020-goog