Re: [PATCH v3] media: nxp: imx8-isi: remove kzalloc_objs

From: Laurent Pinchart

Date: Wed Nov 11 2026 - 02:20:41 EST


Please see my comments on v1.

On Tue, Nov 10, 2026 at 06:28:22PM -0800, Rosen Penev wrote:
> Use a flexible array member to combine allocations.
>
> It looks like pipes never gets freed anywhere. Meaning this effectively
> fixes a memory leak.
>
> Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
> v3: use devm_kzalloc_flex
> v2: add fixes tag, fix typo, and move pdata assignment to original
> place.
> drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 10 ++++------
> drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h | 3 ++-
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 2005584a1215..dcf6c25d7faa 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -473,24 +473,22 @@ static const struct dev_pm_ops mxc_isi_pm_ops = {
>
> static int mxc_isi_probe(struct platform_device *pdev)
> {
> + const struct mxc_isi_plat_data *pdata;
> struct device *dev = &pdev->dev;
> struct mxc_isi_dev *isi;
> unsigned int dma_size;
> unsigned int i;
> int ret = 0;
>
> - isi = devm_kzalloc_obj(dev, *isi);
> + pdata = of_device_get_match_data(dev);
> + isi = devm_kzalloc_flex(dev, *isi, pipes, pdata->num_channels);
> if (!isi)
> return -ENOMEM;
>
> isi->dev = dev;
> platform_set_drvdata(pdev, isi);
>
> - isi->pdata = of_device_get_match_data(dev);
> -
> - isi->pipes = kzalloc_objs(isi->pipes[0], isi->pdata->num_channels);
> - if (!isi->pipes)
> - return -ENOMEM;
> + isi->pdata = pdata;
>
> isi->num_clks = devm_clk_bulk_get_all(dev, &isi->clks);
> if (isi->num_clks < 0)
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> index 58b47335afc7..3165a65391c1 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h
> @@ -297,7 +297,6 @@ struct mxc_isi_dev {
> struct regmap *gasket;
>
> struct mxc_isi_crossbar crossbar;
> - struct mxc_isi_pipe *pipes;
> struct mxc_isi_m2m m2m;
>
> struct media_device media_dev;
> @@ -305,6 +304,8 @@ struct mxc_isi_dev {
> struct v4l2_async_notifier notifier;
>
> struct dentry *debugfs_root;
> +
> + struct mxc_isi_pipe pipes[];
> };
>
> extern const struct mxc_gasket_ops mxc_imx8_gasket_ops;

--
Regards,

Laurent Pinchart