Re: [PATCH v9 11/15] alpha: Remove alpha_ prefix from custom syscall entries
From: Magnus Lindholm
Date: Wed Nov 11 2026 - 02:43:41 EST
Hi André
On Thu, Nov 5, 2026 at 9:26 PM André Almeida <andrealmeid@xxxxxxxxxx> wrote:
>
> Some architectures need special entry points for some syscalls (like
> clone3). The current approach is, instead of having a special name like
> arch_syscall, to name if as __syscall. This is enough to different the
> common entry point to the architecture specific entry point.
>
> Change alpha special syscall entries to do the same. This makes easier to
> join the syscall tables. Leave alpha_syscall_zero because this syscall only
> exists in alpha anyway.
>
> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx>
> ---
> Changes from v7:
> - Fix __clone3 entry
> ---
> arch/alpha/kernel/entry.S | 8 ++++----
> arch/alpha/kernel/syscalls/syscall.tbl | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S
> index 790389a15c3c..25d05f45512d 100644
> --- a/arch/alpha/kernel/entry.S
> +++ b/arch/alpha/kernel/entry.S
> @@ -729,9 +729,9 @@ ret_from_kernel_thread:
>
> .macro fork_like name
> .align 4
> - .globl alpha_\name
> - .ent alpha_\name
> -alpha_\name:
> + .globl __sys_\name
> + .ent __sys_\name
> +__sys_\name:
> .prologue 0
> bsr $1, do_switch_stack
> // NB: if anyone adds preemption, this block will need to be protected
> @@ -746,7 +746,7 @@ alpha_\name:
> ldq $26, 56($sp)
> lda $sp, SWITCH_STACK_SIZE($sp)
> ret
> -.end alpha_\name
> +.end __sys_\name
> .endm
>
> fork_like fork
> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index 8fc4701a6328..59eb066a40bf 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl
> @@ -9,7 +9,7 @@
> #
> 0 common osf_syscall alpha_syscall_zero
> 1 common exit sys_exit
> -2 common fork alpha_fork
> +2 common fork __sys_fork
> 3 common read sys_read
> 4 common write sys_write
> 5 common osf_old_open sys_ni_syscall
> @@ -72,7 +72,7 @@
> 63 common getpgrp sys_getpgrp
> 64 common getpagesize sys_getpagesize
> 65 common osf_mremap sys_ni_syscall
> -66 common vfork alpha_vfork
> +66 common vfork __sys_vfork
> 67 common stat sys_newstat
> 68 common lstat sys_newlstat
> 69 common osf_sbrk sys_ni_syscall
> @@ -242,7 +242,7 @@
> 309 common get_kernel_syms sys_ni_syscall
> 310 common syslog sys_syslog
> 311 common reboot sys_reboot
> -312 common clone alpha_clone
> +312 common clone __sys_clone
> 313 common uselib sys_uselib
> 314 common mlock sys_mlock
> 315 common munlock sys_munlock
> @@ -474,7 +474,7 @@
> 542 common fsmount sys_fsmount
> 543 common fspick sys_fspick
> 544 common pidfd_open sys_pidfd_open
> -545 common clone3 alpha_clone3
> +545 common clone3 __sys__clone3
> 546 common close_range sys_close_range
> 547 common openat2 sys_openat2
> 548 common pidfd_getfd sys_pidfd_getfd
>
> --
> 2.56.0
>
>
This conflicts with my Alpha for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/lindholm/alpha.git
branch: for-next
Commit d38895ba9330 ("alpha: dispatch system calls from C") removes
the fork_like assembly wrappers and changes the table entries to
sys_fork, sys_vfork, sys_clone and sys_clone3.
Consequently, this rename is no longer needed when integrating your
series on top of that branch. I skipped this patch for my integration
test and retained those existing entries.
My for-next is registered with linux-next, so this is an interaction
we should account for when the trees are combined.
Thanks,
Magnus