Re: [PATCH v2 1/8] x86/xen/pv: Don't setup runstate area too early

From: Juergen Gross

Date: Wed Nov 11 2026 - 02:48:38 EST


On 19.10.26 11:20, Teddy Astie wrote:
Le 16/10/2026 à 19:34, Andrew Cooper a écrit :
On 16/10/2026 6:06 pm, Teddy Astie wrote:
This is no longer required since [1].

At this moment of boot, per_cpu areas are not initialized, which prevents
using VCPUOP_register_runstate_phys_area as per_cpu_ptr_to_phys() would
misbehave in this case.

This isn't really correct.

The per-cpu area for the BSP is within the main image, which is why the
logic functions today.  What's missing is the call to
pcpu_setup_first_chunk() which tells per_cpu_ptr_to_phys() about where
the BSP data is.

I think you want to say:

"A future change wants to use per_cpu_ptr_to_phys() in
xen_setup_runstate_info(), but this call is too early.  It turns out to
be no longer required since ..."


Right, I was thinking that the use of the per_cpu was incorrect at this point. But that's not exactly the issue here.

Will adjust for the v3.
With the suggested wording above:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature