Re: [PATCH v2 1/2] dt-bindings: crypto: ice: Document sm8150 inline crypto engine

From: Krzysztof Kozlowski

Date: Wed Nov 11 2026 - 02:50:39 EST


On 11/11/2026 05:23, Andrew Gigena wrote:
>> This part should be a separate commit.
>
> I splitted it into two commits in v3:
> 1. Add qcom,sm8150-inline-crypto-engine compatible.
> 2. Move qcom,sm8150-ufshc to the standalone-ICE UFS binding.
>

No clue what's this about, you completely cut context.

>> And what about eight clock? All existing DTS will report warning? I
>> don't quite get the need of this move.
>
> After the move, SM8150 UFS no longer provides the ICE register region or
> ice_core_clk; those live in the standalone ICE node. The only in-tree
> user of qcom,sm8150-ufshc is arch/arm64/boot/dts/qcom/sm8150.dtsi, which

So you introduce the warning at this point?

> is converted in the DTS patch, so there are no leftover users of the
> embedded-ICE binding for this compatible and no schema warnings.


Best regards,
Krzysztof