Re: [PATCH] drm/bridge: analogix_dp: Fix runtime PM refcount leak in set_bridge()
From: Xiangwu Lai
Date: Wed Nov 11 2026 - 03:07:20 EST
From: laixiangwu <laixiangwu@xxxxxxxxxxxxxxxxxxxx>
Hi,
thanks for the review. You are right: since 917c8d192ba6ad
("drm/bridge: analogix_dp: don't wait for PLL lock too early") removed
the PLL lock polling loop, analogix_dp_init_analog_func() only
performs register writes and always returns 0, so the error check
this patch tried to fix is dead code and the leak it addressed cannot
actually happen.
Instead of keeping a fix for an unreachable path, v2 drops the dead
error check and makes the function void.
v2 follows shortly.
Best regards,
laixiangwu