Re: [PATCH v4 01/25] accel/qda: Add QDA driver documentation
From: Ekansh Gupta
Date: Wed Nov 11 2026 - 03:40:44 EST
On 03-11-2026 19:49, Daniel Pereira wrote:
> On Sun, Nov 01, 2026 07:37 PM, Ekansh Gupta
> <ekansh.gupta@xxxxxxxxxxxxxxxx> wrote:
>>
> Hi Ekansh,
>
> The document reads well. I only have a few wording and consistency nits:
>
>> +The driver binds to the device-tree nodes described by
>
> The kernel documentation spells it "devicetree" (no hyphen). The same
> applies to the other "device-tree" occurrences in the file.
>
>> +4. **Context banks** (``qda_cb``): creates a platform device for each
>> ...
>> + They are created before the accel device is registered
>
> "They" is ambiguous here (the platform devices or the context banks).
> Consider naming the subject.
Thanks, will fix these.
>
> Thanks,
> Daniel