Re: [PATCH v6 1/3] dt-bindings: phy: Add CIX Sky1 USB3 PHY
From: Hongliang Yang
Date: Wed Nov 11 2026 - 03:43:58 EST
> This clearly shows two phys - each node with cell=0, means each having
> one phy. Two nodes, so two phys.
Right, v5 made two phy objects. That was the bug: they were the same
PHY.
The block has two lanes, one per Type-A port: USB4 uses one lane, USB5
the other. Both lanes are programmed through the same register block,
with the same clocks, the same resets and the same init sequence. In v5
the driver created one phy object per child node and gave both the same
drvdata, so the second object programmed exactly the same registers as
the first; the only difference between them was the of_node they were
registered with.
v6 removes that duplicate. One phy object remains; both lanes are still
programmed by the same init sequence, and both Type-A controllers still
get a working PHY. Nothing was dropped.
Best regards,
Hongliang Yang