Re: [PATCH 2/4] ksm: skip rmap_item allocation for non-zero pages under only_merge_zero_pages

[David Hildenbrand (Arm)]

On 11/11/26 09:36, Xu Xin (vivo) wrote:
>> On Tue, Nov 10, 2026 at 07:22:06PM +0800, Xu Xin (vivo) wrote:
>>>
>>> Indeed, the description was generated by LLM, but I thought that was clear enough
>>> to present what this patch do and why. Aparrently, you don't like that style, I'll
>>> rewrite that by handd.
>>
>> In general we never want LLM-generated commit messages/comments.
>>
>> I do however obviously appreciate and empathise with using it to assist
>> non-native speakers. So that's fine, but ideally you would write it up yourself
>> and then have the LLM do simply a polishing layer, keeping the length as small
>> as possible, which should give us the best of both worlds. Thanks :)
>>
>>>
>>> The goal is only to avoid rmap_item allocation for pages that can never merge
>>> under only_merge_zero_pages. The implementation is simple.
>>>
>>> I'll send a v3 with those changes.
>>
>> Well let's wait on David's POV on this series for this cycle before a respin
>> first thanks!
> 
> Thanks Lorenzo, makes sense.
> 
> Hi David,

Hi all,

> 
> What are your thoughts on targeting this series for this cycle? I understand
> you have a lot on your plate having just taken over mm/core.git and are
> focusing on bugfixes right now, so I'm fine with deferring this to the next
> cycle even though the implementation itself is fairly straightforward.

Patch #1 is rather trivial to review () although I will have comments.

Patch #2 needs more thought.

I don't mind something that is easy+quick to review, but if it takes way more
time, it will have to wait, unfortunately.

So the cleaner you make your code, and the easier it will be for us to review,
the easier it is to make it go upstream.

Schloppy LLM text achieves the opposite :)

-- 
Cheers,

David