Re: [PATCH] drm/radeon: Consistently define pci_device_ids using named initializers

[Uwe Kleine-König (The Capable Hub)]

On Wed, Jun 10, 2026 at 06:56:35PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
> 
> On Thu, Apr 30, 2026 at 12:29:57PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > ... and PCI device helpers.
> > 
> > The struct pci_device_id array of supported device was initialized
> > by list expressions. This isn't easily readable if you're not into PCI.
> > 
> > Use PCI_DEVICE* helper macros and named initializers which is more
> > explicit and thus easier to parse. Also skip explicit assignments of 0
> > (which the compiler then takes care of).
> > 
> > The secret plan is to make struct pci_device_id::driver_data an
> > anonymous union (similar to
> > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@xxxxxxxxxxxx/)
> > and that requires named initializers. But it's also a nice cleanup on
> > its own.
> > 
> > This change doesn't introduce changes to the compiled pci_device_id
> > array. Tested on x86 and arm64.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> 
> Similar to the amdgpu driver patch I just pinged, this patch would also
> be great if it made it in for 7.2-rc1. Please?

That didn't work and it failed to go into 7.4-rc1 either :-\ It still
applies to next-20261110, is it still on your radar?

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature