Re: [PATCH] phy: hisilicon: fix UTMI reset leaks in INNO USB2 PHY

[Philipp Zabel]

On Mi, 2026-11-11 at 16:59 +0800, Xia Yan wrote:
> hisi_inno_phy_probe() acquires an exclusive UTMI reset control for each
> child node but never releases it on probe failure or driver detach.
> The leaked controls remain acquired, so a later probe can fail with
> -EBUSY when requesting the same resets.
> 
> Register a devres action after each successful lookup to release the
> control on probe failure and detach.
> 
> Found during source review of reset-control lifetimes.
> 
> Build-tested the driver object on x86_64 with W=1 and reset support
> enabled. No hardware testing.
> 
> Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
> Cc: stable@xxxxxxxxxxxxxxx # needs of_node_put(child) on <= 6.6
> Signed-off-by: Xia Yan <yanxia@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

It looks like an equivalent to devm_get_clk_from_child() for reset
controls could be useful.

regards
Philipp