Re: [PATCH v4 10/20] mfd: Use named initializers for acpi_device_id arrays

[Uwe Kleine-König (The Capable Hub)]

[adding Pawel to Cc:]

Hello Andy,

On Wed, Nov 11, 2026 at 10:45:47AM +0200, Andy Shevchenko wrote:
> On Tue, Nov 10, 2026 at 10:54:35PM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> > While being less compact, using named initializers allows to more easily
> > see which members of the structs are assigned which value without having
> > to lookup the declaration of the struct. And it's also more robust
> > against changes to the struct definition.
> > 
> > The mentioned robustness is relevant for a planned change to struct
> > acpi_device_id that replaces .driver_data by an anonymous union.
> > 
> > This patch doesn't modify the compiled arrays, only their representation
> > in source form benefits.
> 
> I don't know who is the first, you, guys, collaborate together and come up with
> a solution, but I have reviewed already this
> https://lore.kernel.org/lkml/20261104-acpi-mfd-v2-0-64b9dee3baaf@xxxxxxxxxxxxxxxxxxxx/

Oh, I wasn't aware that Pawel is still on that. Initially we had a list
where Pawel indeed was assigned for acpi_device_id. Since then I went on
to do these changes per subsystem for several *_device_id at once
(instead of per *_device_id and subsystem) and stopped looking after the
initial list. I might have mentioned that in our internal chat, but I
take the blame on the lack of coordination.

Looking through the differences I found:

 - different commit log
 - I have a cleanup to drivers/mfd/kempld-core.c which conflicts with
   Pawel's series

@Lee: If you take Pawel's series, I can rebase and resend. Most of my
patches still apply just fine on top of Pawel's series, so you can
preempt parts of my rebase using

	b4 am -P 1,2,4-6,8,9,11-15,17-20 cover.1794347059.git.u.kleine-koenig@xxxxxxxxxxxx

Just give me a poke when you made up your mind how to proceed and sorry
for missing that conflict.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature