[PATCH 1/2] tpm: Disable a TPM that stops responding
From: Breno Leitao
Date: Wed Nov 11 2026 - 05:03:06 EST
A TPM that stops responding fails each command only after the transport
timeout, and its callers keep sending more: the hwrng thread every 10
seconds forever, and userspace through /dev/tpmrm0. Each attempt holds
tpm_mutex for the whole timeout and logs an error:
tpm tpm0: invalid TPM_STS.x 0xff, dumping stack for forensics
tpm tpm0: tpm_try_transmit: send(): error -62
tpm tpm0: tpm_try_transmit: send(): error -62
...
The core already stops using a TPM it cannot trust: tpm_try_get_ops()
fails with -EIO once TPM_CHIP_FLAG_DISABLE is set, which
tpm2_load_null() does when it cannot restore the null key. Set the same
flag when commands have kept timing out for ten minutes, with none
completing in between.
A completed command, whatever its TPM return code, resets the clock. A
disabled TPM stays disabled until the driver is rebound or the machine
reboots.
Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
---
drivers/char/tpm/tpm-interface.c | 29 +++++++++++++++++++++++++++++
include/linux/tpm.h | 2 ++
2 files changed, 31 insertions(+)
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index e0385b16616b46..c6278ef8d1095e 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -30,6 +30,8 @@
#include "tpm.h"
+#define TPM_UNRESPONSIVE_TIMEOUT (10 * 60 * HZ)
+
/*
* Bug workaround - some TPM's don't flush the most
* recently changed pcr on suspend, so force the flush
@@ -206,6 +208,31 @@ static ssize_t tpm_try_transmit(struct tpm_chip *chip, void *buf, size_t bufsiz)
return rc ? rc : len;
}
+/*
+ * Disable the TPM once commands keep timing out for TPM_UNRESPONSIVE_TIMEOUT.
+ * A few timeouts are not enough: some TPMs stall for half a minute and recover.
+ */
+static void tpm_check_unresponsive(struct tpm_chip *chip, ssize_t ret)
+{
+ if (ret >= 0) {
+ chip->nr_timeouts = 0;
+ return;
+ }
+ if (ret != -ETIME || (chip->flags & TPM_CHIP_FLAG_DISABLE))
+ return;
+ if (!chip->nr_timeouts++) {
+ chip->first_timeout = jiffies;
+ return;
+ }
+ if (time_before(jiffies,
+ chip->first_timeout + TPM_UNRESPONSIVE_TIMEOUT))
+ return;
+
+ dev_err(&chip->dev, "%u commands timed out in %lu seconds, disabling the TPM\n",
+ chip->nr_timeouts, (jiffies - chip->first_timeout) / HZ);
+ chip->flags |= TPM_CHIP_FLAG_DISABLE;
+}
+
/**
* tpm_transmit - Internal kernel interface to transmit TPM commands.
* @chip: a TPM chip to use
@@ -268,6 +295,8 @@ ssize_t tpm_transmit(struct tpm_chip *chip, u8 *buf, size_t bufsiz)
delay_msec *= 2;
memcpy(buf, save, save_size);
}
+
+ tpm_check_unresponsive(chip, ret);
return ret;
}
diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index 0db277af45c393..4264c87a04d98c 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -131,6 +131,8 @@ struct tpm_chip {
struct hwrng hwrng;
struct mutex tpm_mutex; /* tpm is processing */
+ unsigned int nr_timeouts; /* consecutive command timeouts */
+ unsigned long first_timeout; /* jiffies */
unsigned long timeout_a; /* jiffies */
unsigned long timeout_b; /* jiffies */
--
2.53.0-Meta