Re: [PATCH net v8 1/4] can: j1939: serialize cancel and rearm of the receive timer
From: Chaosheng Qu
Date: Wed Nov 11 2026 - 05:43:17 EST
Hi Oleksij,
Not a secret at all — and thanks for asking rather than assuming. (My mail
client lost the thread id of your message, so I am hanging this off the v8
patch it is about; apologies for that.)
The model is DeepSeek V4.1 Flash (`deepseek-v4.1-flash`), run through an agentic
coding harness rather than a chat window: it reads the tree, builds the file,
runs checkpatch and drafts the changelog. The analysis, the judgement calls and
the mistakes are mine. v9 carries `Assisted-by: LLM` on all four patches, which
is what `Documentation/process/coding-assistants.rst` asks for — that tag was
missing in v8, and that was my omission.
One thing about your attachment: it did not reach me. What I received has the
line "In attachment is an extract from my setup" and nothing attached, so I have
not seen it. If it is a config or a prompt/setup you use to get better patches
out, please paste it inline and I will read it properly — I would rather learn
from your setup than guess at it.
On the first sentence: fixed in v9, all four changelogs now open in the
imperative.
[1/4] Cancel and rearm the receive timer as one atomic step under
active_session_list_lock.
[2/4] Validate the packet number in ETP.CM_DPO, which is peer controlled and
currently accepted without any check.
[3/4] Check the skb that j1939_session_completed() hands to j1939_sk_recv(),
which dereferences oskb->sk.
[4/4] Reject a CTS packet number above pkt.total in j1939_xtp_rx_cts_one().
v9 is out. Code is functionally the same as v8 except one comment in [2/4]; the
rest is the changelogs, the missing Fixes/Cc: stable tags and the cover letter.
Thanks also for holding the duplicate patch on the Sun Yiqi thread for this one.
I would rather get it right than get it in first.
Chaosheng