Re: [PATCH v12 0/3] crypto - qce: fix self-test issues in aead
From: Herbert Xu
Date: Wed Nov 11 2026 - 06:20:38 EST
On Tue, Oct 20, 2026 at 02:47:00PM +0200, Bartosz Golaszewski wrote:
> As requested by Herbert: this is the aead part of the QCE fixes sent
> separately for easier review.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
> Changes in v12:
> - clear the ctx->need_fallback flag for key sizes other than AES-192
> (sashiko)
> - Link to v11: https://patch.msgid.link/20261019-qce-fixes-aead-v11-0-11c55cc7a695@xxxxxxxxxxxxxxxx
>
> Changes in v11:
> - Split out the aead patches into a smaller series for easier review
> - add a patch fixing a race condition resulting from sharing
> ctx->eed_fallback by concurrent requests
> - Link to v10: https://patch.msgid.link/20261013-qce-fix-self-tests-v10-0-57162a38a554@xxxxxxxxxxxxxxxx
>
> Changes in v10:
> - don't pass a NULL buffer to sg_init_one()
> - fix byte order of the imported hash state on empty finalization
> - don't recompute the CTR counter in software for every request
> - reject skcipher requests with a too short scatterlist
> - check fragmentation for empty CCM decryption requests too
> - don't use a static loop iterator (duh...)
> - initialize the return value in qce_handle_queue()
> - Link to v9: https://patch.msgid.link/20260922-qce-fix-self-tests-v9-0-b1aa742e79af@xxxxxxxxxxxxxxxx
>
> Changes in v9:
> - Rebase on top of cryptodev/master
> - Rephrase Kconfig help text changes
> - Link to v8: https://patch.msgid.link/20260921-qce-fix-self-tests-v8-0-107537869a72@xxxxxxxxxxxxxxxx
>
> Changes in v8:
> - Add a patch making the crypto driver *not* register algos by default
> but only if the user explicitly requests it with the provided module
> parameter
> - Use the "offloader" name for the crypto IP instead of "accelerator"
> - Fix device module table issues
> - Make the core driver use a list (despite it only having a single
> member now) of child auxiliary devices to register to make it clear we
> have the intention of extending this once we start the work on secure
> media playback
> - Link to v7: https://patch.msgid.link/20260910-qce-fix-self-tests-v7-0-cdbd2718af14@xxxxxxxxxxxxxxxx
>
> Changes in v7:
> - Add follow-up changes converting the QCE crypto driver to auxiliary
> bus, adding the core QCE driver under drivers/soc/ registering the
> auxiliary device and removing the BROKEN Kconfig label
> - Link to v6: https://patch.msgid.link/20260717-qce-fix-self-tests-v6-0-455775fe5f6c@xxxxxxxxxxxxxxxx
>
> Changes in v6:
> - Handle all zero-length HMAC finalizations (like imported state with
> data already hashed), not only the genuinely empty message case
> - Add an additional patch addressing the fragmented skcipher payload
> issue
> - Link to v5: https://patch.msgid.link/20260706-qce-fix-self-tests-v5-0-86f461ff1829@xxxxxxxxxxxxxxxx
>
> Changes in v5:
> - Dropped patch 1/8 that's already queued
> - Use the pre-allocated fallback ahash for HMAC transforms (Herbert)
> - Link to v4: https://patch.msgid.link/20260622-qce-fix-self-tests-v4-0-4f82ffa716c6@xxxxxxxxxxxxxxxx
>
> Changes in v4:
> - Remove remaining ECB and DES3 bits
> - Pick up tags
> - Link to v3: https://patch.msgid.link/20260617-qce-fix-self-tests-v3-0-ecc2b4dedcfd@xxxxxxxxxxxxxxxx
>
> Changes in v3:
> - Remove even more algorithms and dead code in patch 1/8
> - Link to v2: https://patch.msgid.link/20260615-qce-fix-self-tests-v2-0-dc911f1aad42@xxxxxxxxxxxxxxxx
>
> Changes in v2:
> - Add fixes for the full suite of crypto self-tests
> - Add Fixes and Cc tags
> - Link to v1: https://patch.msgid.link/20260610-qce_selftest_fix-v1-0-1b0504783a46@xxxxxxxxxxxxxxxx/
>
> ---
> Bartosz Golaszewski (3):
> crypto: qce - Don't modify the TFM context for per-request fallback
> crypto: qce - Use a fallback for CCM with a partial final block
> crypto: qce - Use fallback for CCM with a fragmented payload
>
> drivers/crypto/qce/aead.c | 46 ++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 36 insertions(+), 10 deletions(-)
> ---
> base-commit: 0aac16003b01b9282491ea3d454697c2dc7e8c78
> change-id: 20261019-qce-fixes-aead-e229fa2015e3
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
All applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt