Re: [PATCH] nbd: fix circular lock dependency

From: Timo Joannin

Date: Wed Nov 11 2026 - 06:29:38 EST


On Wed, Nov 11, 2026 at 0:40 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> Moving nbd_get_socket() makes this patch much larger than necessary,
> which makes reviewing and backporting it harder. Adding a single
> nbd_reclassify_socket(sock) call in nbd_genl_reconnect_sock_cb() right
> after the nbd_get_socket() call is sufficient.

Hi Guilherme and Bart,

Thanks for working on this! I'm currently fixing a possible deadlock
in wg_ratelimiter_uninit
(Reported-by: syzbot+72fceb8393e04ce876d9@xxxxxxxxxxxxxxxxxxxxxxxxx)
involving cpu_hotplug_lock and slab_mutex.

My one syzbot test failed because of this lockdep
false positive that this patch addresses. I applied Bart's suggested 1-line
fix locally, and will see if it resolves the false positive.
I will be submitting my cpu_hotplug_lock fix separately.
I am looking forward to see your v2!

Thanks,
Timo Joannin