[PATCH] regulator: tps65132: Fix incorrect bits for VNEG/VPOS discharge
From: Ben Grisdale via B4 Relay
Date: Wed Nov 11 2026 - 07:52:05 EST
From: Ben Grisdale <bengris32@xxxxxxxxxxxxx>
According to the TPS65132 datasheet [1], DISN (VNEG active discharge) is
bit 0 of register 0x03, while DISP (VPOS active discharge) is bit 1, as
described in Table 6. The driver currently has them swapped around, so
setting the active discharge of one output changes it on the other.
Swap the bit definitions to be consistent with the datasheet.
Fixes: 77c129bfefc8 ("regulator: tps65132: add regulator driver for TI TPS65132")
Link: https://www.ti.com/lit/ds/symlink/tps65132.pdf [1]
Signed-off-by: Ben Grisdale <bengris32@xxxxxxxxxxxxx>
---
drivers/regulator/tps65132-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/tps65132-regulator.c b/drivers/regulator/tps65132-regulator.c
index 912db82ab51d..42388a170116 100644
--- a/drivers/regulator/tps65132-regulator.c
+++ b/drivers/regulator/tps65132-regulator.c
@@ -37,8 +37,8 @@
#define TPS65132_VOUT_VMAX 6000000
#define TPS65132_VOUT_STEP 100000
-#define TPS65132_REG_APPS_DIS_VPOS BIT(0)
-#define TPS65132_REG_APPS_DIS_VNEG BIT(1)
+#define TPS65132_REG_APPS_DIS_VNEG BIT(0)
+#define TPS65132_REG_APPS_DIS_VPOS BIT(1)
#define TPS65132_REGULATOR_ID_VPOS 0
#define TPS65132_REGULATOR_ID_VNEG 1
---
base-commit: 793807ca13bf3072fc6d16ce6d90e9ab9beff2a5
change-id: 20261111-tps65132-discharge-fix-ebde09049344
Best regards,
--
Ben Grisdale <bengris32@xxxxxxxxxxxxx>