Re: [PATCH] ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72

From: Fa-Iz Faadhillah Ibrahim

Date: Wed Nov 11 2026 - 07:52:58 EST


On Wednesday, November 11, 2026 3:59:36 PM Western Indonesia Time Takashi Iwai wrote:
> On Wed, 11 Nov 2026 03:13:28 +0100,
> Fa-Iz Faadhillah Ibrahim wrote:
> >
> > fix micmute LED for Acer Predator PHN16-72.
> >
> > Signed-off-by: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@xxxxxxxxx>
> > ---
> > sound/hda/codecs/realtek/alc269.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> > index a756e0076021..fa78a36bba5f 100644
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -7553,6 +7553,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x1025, 0x170f, "Acer Predator PHN16-71", ALC2XX_FIXUP_HEADSET_MIC),
> > SND_PCI_QUIRK(0x1025, 0x171e, "Acer Nitro ANV15-51", ALC245_FIXUP_ACER_MICMUTE_LED),
> > SND_PCI_QUIRK(0x1025, 0x172c, "Acer Nitro ANV16-41", ALC2XX_FIXUP_HEADSET_MIC),
> > + SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC245_FIXUP_ACER_MICMUTE_LED),
> > SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC2XX_FIXUP_HEADSET_MIC),
>
> You see that there is already an entry for 1025:1731.
> You should replace it with the new quirk instead of appending yet
> another.
thanks for the correction, yes I should've replaced it instead.
>
> And, please elaborate a bit more. You're changing the existing quirk,
> so you'd need to show that there is no regression by your change.
I can confirm that the headset mic fixed by the existing quirk does still
work properly with the new quirk, what do i need to show exactly?
>
>
> thanks,
>
> Takashi
>
Thanks,
Fa-Iz Faadhillah Ibrahim

Attachment: signature.asc
Description: This is a digitally signed message part.