Re: [PATCH v7 3/5] iommu/of: Make OF_IOMMU depend on OF_ADDRESS

From: Dmitry Baryshkov

Date: Wed Nov 11 2026 - 08:23:51 EST


On Fri, Nov 06, 2026 at 10:44:26PM +0530, Vikash Garodia wrote:
> The OF_IOMMU code relies on OF address parsing helpers, but the
> dependency on OF_ADDRESS is not expressed in Kconfig. As a result,
> of_iommu.c contains CONFIG_OF_ADDRESS guards and a __maybe_unused
> annotation to handle configurations where OF_ADDRESS is disabled.
>
> Make OF_IOMMU depend on OF_ADDRESS and remove the now unnecessary
> preprocessor guards and __maybe_unused annotation.

Why? What's the problem that you are solving? Why is the current code
bad?

>
> The only architecture supporting OF without OF_ADDRESS is SPARC, which
> does not use OF_IOMMU, so no functional change is intended.
>
> Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> Co-developed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> ---
> drivers/iommu/Kconfig | 2 +-
> drivers/iommu/of_iommu.c | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>

--
With best wishes
Dmitry