[PATCH v3 1/2] x86/lib: Keep the scalar memcpy() count in RCX
From: Usama Arif
Date: Wed Nov 11 2026 - 08:31:27 EST
Use RCX for the scalar loop count and tail indexing, and RDX for the
small-copy data temporary. Initialize RCX from the incoming RDX count in
memcpy_orig().
This prepares the ERMS size check to use RDX as scratch while preserving
the REP MOVSB count in RCX. The FSRM path and copy policy stay the same.
No functional change.
Signed-off-by: Usama Arif <usama.arif@xxxxxxxxx>
---
arch/x86/lib/memcpy_64.S | 59 ++++++++++++++++++++--------------------
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/arch/x86/lib/memcpy_64.S b/arch/x86/lib/memcpy_64.S
index 12a23fa7c44c5..7bb146c811029 100644
--- a/arch/x86/lib/memcpy_64.S
+++ b/arch/x86/lib/memcpy_64.S
@@ -46,8 +46,9 @@ EXPORT_SYMBOL(memcpy)
SYM_FUNC_START_LOCAL(memcpy_orig)
movq %rdi, %rax
+ movq %rdx, %rcx
- cmpq $0x20, %rdx
+ cmpq $0x20, %rcx
jb .Lhandle_tail
/*
@@ -56,9 +57,9 @@ SYM_FUNC_START_LOCAL(memcpy_orig)
*/
cmp %dil, %sil
jl .Lcopy_backward
- subq $0x20, %rdx
+ subq $0x20, %rcx
.Lcopy_forward_loop:
- subq $0x20, %rdx
+ subq $0x20, %rcx
/*
* Move in blocks of 4x8 bytes:
@@ -75,23 +76,23 @@ SYM_FUNC_START_LOCAL(memcpy_orig)
movq %r11, 3*8(%rdi)
leaq 4*8(%rdi), %rdi
jae .Lcopy_forward_loop
- addl $0x20, %edx
+ addl $0x20, %ecx
jmp .Lhandle_tail
.Lcopy_backward:
/*
* Calculate copy position to tail.
*/
- addq %rdx, %rsi
- addq %rdx, %rdi
- subq $0x20, %rdx
+ addq %rcx, %rsi
+ addq %rcx, %rdi
+ subq $0x20, %rcx
/*
* At most 3 ALU operations in one cycle,
* so append NOPS in the same 16 bytes trunk.
*/
.p2align 4
.Lcopy_backward_loop:
- subq $0x20, %rdx
+ subq $0x20, %rcx
movq -1*8(%rsi), %r8
movq -2*8(%rsi), %r9
movq -3*8(%rsi), %r10
@@ -107,11 +108,11 @@ SYM_FUNC_START_LOCAL(memcpy_orig)
/*
* Calculate copy position to head.
*/
- addl $0x20, %edx
- subq %rdx, %rsi
- subq %rdx, %rdi
+ addl $0x20, %ecx
+ subq %rcx, %rsi
+ subq %rcx, %rdi
.Lhandle_tail:
- cmpl $16, %edx
+ cmpl $16, %ecx
jb .Lless_16bytes
/*
@@ -119,53 +120,53 @@ SYM_FUNC_START_LOCAL(memcpy_orig)
*/
movq 0*8(%rsi), %r8
movq 1*8(%rsi), %r9
- movq -2*8(%rsi, %rdx), %r10
- movq -1*8(%rsi, %rdx), %r11
+ movq -2*8(%rsi, %rcx), %r10
+ movq -1*8(%rsi, %rcx), %r11
movq %r8, 0*8(%rdi)
movq %r9, 1*8(%rdi)
- movq %r10, -2*8(%rdi, %rdx)
- movq %r11, -1*8(%rdi, %rdx)
+ movq %r10, -2*8(%rdi, %rcx)
+ movq %r11, -1*8(%rdi, %rcx)
RET
.p2align 4
.Lless_16bytes:
- cmpl $8, %edx
+ cmpl $8, %ecx
jb .Lless_8bytes
/*
* Move data from 8 bytes to 15 bytes.
*/
movq 0*8(%rsi), %r8
- movq -1*8(%rsi, %rdx), %r9
+ movq -1*8(%rsi, %rcx), %r9
movq %r8, 0*8(%rdi)
- movq %r9, -1*8(%rdi, %rdx)
+ movq %r9, -1*8(%rdi, %rcx)
RET
.p2align 4
.Lless_8bytes:
- cmpl $4, %edx
+ cmpl $4, %ecx
jb .Lless_3bytes
/*
* Move data from 4 bytes to 7 bytes.
*/
- movl (%rsi), %ecx
- movl -4(%rsi, %rdx), %r8d
- movl %ecx, (%rdi)
- movl %r8d, -4(%rdi, %rdx)
+ movl (%rsi), %edx
+ movl -4(%rsi, %rcx), %r8d
+ movl %edx, (%rdi)
+ movl %r8d, -4(%rdi, %rcx)
RET
.p2align 4
.Lless_3bytes:
- subl $1, %edx
+ subl $1, %ecx
jb .Lend
/*
* Move data from 1 bytes to 3 bytes.
*/
- movzbl (%rsi), %ecx
+ movzbl (%rsi), %edx
jz .Lstore_1byte
movzbq 1(%rsi), %r8
- movzbq (%rsi, %rdx), %r9
+ movzbq (%rsi, %rcx), %r9
movb %r8b, 1(%rdi)
- movb %r9b, (%rdi, %rdx)
+ movb %r9b, (%rdi, %rcx)
.Lstore_1byte:
- movb %cl, (%rdi)
+ movb %dl, (%rdi)
.Lend:
RET
--
2.53.0-Meta