Re: [PATCH v6 03/15] fbdev: efifb: move the BMP headers to <video/bmp.h>

From: Javier Martinez Canillas

Date: Wed Nov 11 2026 - 08:32:10 EST


Màxim Pedraza Padilla <maximpedraza@xxxxxxxxx> writes:

Hello Màxim,

> The DRM splash client parses the same BMP headers as efifb. Rather than
> keep a second copy of the structures, move them to include/video/bmp.h
> with the magic number.
>
> BMP is little endian whatever the CPU, so the header gives the fields
> as __le16 and __le32, and efifb now reads them with
> get_unaligned_le16() and get_unaligned_le32(). Width and height are
> read signed, as the format has them. No change on the little endian
> systems EFI runs on.
>
> Suggested-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Assisted-by: Claude:claude-opus-5-5

Please drop this tag. Has been obsoleted by commit 1e035297ffda ("docs:
remove Assisted-by references").

> Signed-off-by: Màxim Pedraza Padilla <maximpedraza@xxxxxxxxx>
> ---
>

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat