Re: [PATCH] clk: qcom: gcc-sm8750: Use retention for USB power domains

[Abel Vesa]

On 26-11-10 23:33:46, Vladyslav Tymoshchuk wrote:
> The USB controller does not expect to lose its state in system suspend.
> The controller node is a wakeup source, so in host mode dwc3 keeps the
> core initialized across suspend, while genpd still powers the USB GDSCs
> off. With a USB stick on the port, the xHCI comes back from s2idle with
> an SMMU fault and is given up:
> 
>   arm-smmu 15000000.iommu: Unhandled context fault: fsr=0x402, iova=0x669fd3200, fsynr=0x370011, cbfrsynra=0x40, cb=5
>   xhci-hcd xhci-hcd.3.auto: WARNING: Host System Error
>   xhci-hcd xhci-hcd.3.auto: xHCI host not responding to stop endpoint command
>   xhci-hcd xhci-hcd.3.auto: xHCI host controller not responding, assume dead
>   xhci-hcd xhci-hcd.3.auto: HC died; cleaning up
> 
> After that the port is dead in device mode as well, until a reboot.
> 
> Keep the controller and PHY GDSCs in retention, as SM8650 and X1E80100
> do.
> 
> Fixes: 3267c774f3ff ("clk: qcom: Add support for GCC on SM8750")
> Signed-off-by: Vladyslav Tymoshchuk <tvlad744@xxxxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>