Re: [PATCH v8 07/29] drm/msm/dp: add support for MST channel slot allocation
From: Dmitry Baryshkov
Date: Wed Nov 11 2026 - 09:47:36 EST
On Tue, Nov 10, 2026 at 12:54:28PM +0800, Yongxing Mou wrote:
> From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
> DP MST streams share 64 MTP slots in a time-multiplexed manner. Add
> support for calculating the rate governor, slot allocation, and slot
> reservation in the DP controller.
>
> The per-stream slot allocation is not tracked by the driver. Callers
> pass in a msm_dp_mst_slot_info table derived from
> drm_dp_mst_topology_state::payloads, which the MST helpers keep up to
> date, and the controller only translates it into the per-stream
> timeslot registers and the rate governor inputs.
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dp/dp_ctrl.c | 147 +++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/msm/dp/dp_ctrl.h | 4 +-
> drivers/gpu/drm/msm/dp/dp_display.c | 9 ++-
> drivers/gpu/drm/msm/dp/dp_panel.h | 6 ++
> 4 files changed, 161 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> index 8a2396aec6d5e..0b34db3bd5d22 100644
> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> @@ -83,6 +83,7 @@
> #define MR_LINK_PRBS7 0x100
> #define MR_LINK_CUSTOM80 0x200
> #define MR_LINK_TRAINING4 0x40
> +#define DP_MAX_TIME_SLOTS 64
Doesn't seem to be used.
>
> enum {
> DP_TRAINING_NONE,
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry