Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages()
From: Rik van Riel
Date: Wed Nov 11 2026 - 10:24:57 EST
On Tue, 2026-11-10 at 14:06 +0100, David Hildenbrand (Arm) wrote:
> On 11/9/26 13:32, Yeoreum Yun wrote:
> >
> > -static inline bool gup_must_unshare(struct vm_area_struct *vma,
> > - unsigned int flags, struct
> > page *page)
> > +static unsigned long gup_unshared_pages(struct vm_area_struct
> > *vma,
>
> Besides the function name, LGTM.
>
> gup_pages_requiring_unsharing() ? Don't quite like it, but something
> along those
> lines.
FWIW, I'd ack the gup_skip_unshare_pages you proposed
last night ;)
--
All Rights Reversed.