Re: [PATCH v6 8/9] phy: rockchip-samsung-dcphy: Add MIPI D-PHY receiver support
From: Michael Riesch
Date: Wed Nov 11 2026 - 10:30:01 EST
Hi Jason,
Thanks for the patch!
On 11/10/26 09:18, Jason Yang wrote:
> [...]
> +static int samsung_mipi_dphy_rx_power_on(struct samsung_mipi_dcphy *samsung)
> +{
> + struct samsung_mipi_phy *rx = &samsung->rx;
> + int ret;
> +
> + if (!rx->hs_clk_rate || !rx->lanes)
> + return -EINVAL;
> +
> + reset_control_assert(samsung->s_phy_rst);
> +
> + samsung_mipi_dphy_rx_config_common(samsung);
> + samsung_mipi_dphy_rx_config_settle(samsung);
> +
> + ret = samsung_mipi_dphy_rx_lane_enable(samsung);
> +
> + reset_control_deassert(samsung->s_phy_rst);
> +
> + return ret;
> +}
> +
> +static int samsung_mipi_dphy_rx_power_off(struct samsung_mipi_dcphy *samsung)
> +{
> + reset_control_assert(samsung->s_phy_rst);
I wonder whether this is really a D-PHY specific thing. You can keep it
as is for now, I'll try to bring up the C-PHY part on top of your
series, and then we'll see.
> [...]
> static const struct phy_ops samsung_mipi_dcphy_tx_ops = {
> .configure = samsung_mipi_dcphy_tx_configure,
> .power_on = samsung_mipi_dcphy_tx_power_on,
> @@ -1535,6 +1905,15 @@ static const struct phy_ops samsung_mipi_dcphy_tx_ops = {
> .owner = THIS_MODULE,
> };
>
> +static const struct phy_ops samsung_mipi_dcphy_rx_ops = {
> + .configure = samsung_mipi_dcphy_rx_configure,
> + .power_on = samsung_mipi_dcphy_rx_power_on,
> + .power_off = samsung_mipi_dcphy_rx_power_off,
> + .init = samsung_mipi_dcphy_init,
> + .exit = samsung_mipi_dcphy_exit,
> + .owner = THIS_MODULE,
Nit: either align all = or just use a single space (personally I would
prefer the latter).
> [...]
Looks all good to me!
Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxx>
Best regards,
Michael