Re: [PATCH] audit: add missing syscalls to signal class

From: Jeffrey Bencteux

Date: Wed Nov 11 2026 - 10:46:05 EST


On Wed, Nov 11, 2026 at 11:50:48AM -0300, Ricardo Robaina wrote:
> On Wed, Nov 11, 2026 at 11:31 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >
> > On Wed, Nov 11, 2026, at 14:52, Jeffrey Bencteux wrote:
> > > On Wed, Nov 11, 2026 at 12:18:01PM +0100, Arnd Bergmann wrote:
> > >> Why the #ifdef checks? These should be available on all architectures.
> > >
> > > I included them as convention, should they be removed?
> >
> > Not sure where the convention comes from, it just seemed
> > odd that you have the #ifdef checks for the newly added
> > entries but not the ones that are already in this file.
> >
> > I had not checked the other files that have similar ones.
> >
> > Arnd
> >
>
> Hello everyone!
>
> It's not a convention. Arnd is right, ifdef checks should only be used
> for the ones that are not available on all architectures.
>
> Jeffrey, please take a look in this commit c0d73c09381e ("audit: add
> missing syscalls to PERM class tables"). Note that '__NR_statx' is not
> guarded by a ifdef.
>

Arnd, Ricardo,

Thanks, it is now clear to me these are always available.