[PATCH v6 2/3] perf jevents: Make the model argument optional

From: TAKANO Mitsuhiro

Date: Wed Nov 11 2026 - 10:48:10 EST


The model argument carries a default of "all", but a positional argument
with a default and no nargs is still required: "jevents.py x86 <dir>" exits
with "the following arguments are required: model", and so does any caller
that only wants the tables for an architecture.

Make it nargs='?' so the default is reachable and an omitted model means
"all". Builds pass it explicitly, so the generated tables do not change.

Fixes: 5a09b1fd1b1f ("perf jevents: Add model list option")
Signed-off-by: TAKANO Mitsuhiro <takano32@xxxxxxxxx>
---
v6: patch 1 names the file as well as the metric when a MetricExpr is
missing (the tables are read through a worker pool, outside the
walk, so the path was lost). The perf test's one-line description
ends in "(no_mlock)" so perf test lists it whole and the test does
not take a memlock slot. No other change.

tools/perf/pmu-events/jevents.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index 843748915c12..04ef2f488283 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -1487,10 +1487,10 @@ def main() -> None:

ap = argparse.ArgumentParser()
ap.add_argument('arch', help='Architecture name like x86')
- ap.add_argument('model', help='''Select a model such as skylake to
-reduce the code size. Normally set to "all". For architectures like
-ARM64 with an implementor/model, the model must include the implementor
-such as "arm/cortex-a34".''',
+ ap.add_argument('model', nargs='?', help='''Select a model such as skylake to
+reduce the code size. Normally set to "all", and that is what an omitted
+model means. For architectures like ARM64 with an implementor/model, the
+model must include the implementor such as "arm/cortex-a34".''',
default='all')
ap.add_argument(
'starting_dir',
--
2.53.0