Re: [RFC PATCH 5/6] ksmbd: show classic users as S-1-22-1-<uid> on every server

[Ian Bridges]

Hi Jan,

On Tue, Nov 10, 2026 at 09:02:52AM +0000, Jan Koester wrote:
> +	else if (uid_is_legacy(uid))
> +		id_to_sid(from_kuid_munged(&init_user_ns, uid), SIDUNIX_USER, ssid);

smb_check_perm_dacl() seems to still build the caller's own SID in the
old form. For a user other than root, would an ACE that a client writes
for S-1-22-1-<uid> then match the user only through the token? If
ksmbd_user_set_token() builds no token, as when its allocation fails in
4/6, would a deny ACE on the user in the new form stop applying? With a
deny for S-1-22-1-<uid> followed by an allow for Everyone, the user
would then get the access the deny should refuse.

Thanks,
Ian