Re: [RFC PATCH 1/6] ksmbd: don't ignore the owner and group of a descriptor without a DACL

[Ian Bridges]

Hi Jan,

On Tue, Nov 10, 2026 at 09:02:27AM +0000, Jan Koester wrote:
> +	/* parse_sec_desc() rewrites type */
> +	dacl = le16_to_cpu(pntsd->type) & DACL_PRESENT;

Shouldn't the parts to change come from the SecurityInformation of the
request rather than from DACL_PRESENT? As far as I can see, the Linux
cifs client's chown can send OWNER_SECURITY_INFORMATION alone with a
descriptor that still carries the DACL. It does so when no ACE names
the old owner. Would this patch then parse that DACL again, rebuild the
POSIX ACL from it and replace the stored descriptor, though the client
only asked to change the owner? And in the reverse case, would a
request for the DACL alone still change the owner when the descriptor
carries one?

Thanks,
Ian