Re: [PATCH] serial: mps2-uart: Remove the ports_idr entry when probe fails

From: Arnd Bergmann

Date: Wed Nov 11 2026 - 11:34:36 EST


On Wed, Nov 11, 2026, at 15:17, Vladimir Murzin wrote:
> On 11/6/26 01:06, Changyul Lee wrote:
>
> Before getting into the review, I'd like to clarify a few things:
>
> - This driver is only used on a NOMMU platform, where any code
> can write to any memory location, so the security impact of
> this issue is likely minimal
>
> - The only platform that uses this driver is deprecated and
> scheduled for removal [1], with the driver to be removed
> afterwards
>
> @Arnd, could you please advise on how to proceed? Should we
> review the patch, leave things as they are, or take a different
> approach?
>
> [1]
> https://lore.kernel.org/linux-arm-kernel/20260908152808.3928630-12-arnd@xxxxxxxxxx/

I don't think it's super important, either applying as-is
or ignoring seems fine, just don't spend too much time
on a review.

For some of the platforms I'm planning to remove it would
be nice to backport fixesto the LTS kernels in case there
are some users after all.

Chanyul, it looks like you've done a thorough job testing this
patch, and you probably have similar work for other drivers
coming. I would suggest you try to prioritize the drivers that
are likely to be in use somewhere.

I have a branch for removing a lot of drivers including this
one, maybe check your other patches to see which ones are
obsolete.

Arnd

[1] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=board-remove-7.4